[webkit-reviews] review granted: [Bug 9214] Images using QuickTime plugin do not display correctly : [Attachment 22060] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 5 16:19:25 PDT 2008


Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 9214: Images using QuickTime plugin do not display correctly
https://bugs.webkit.org/show_bug.cgi?id=9214

Attachment 22060: Patch v2
https://bugs.webkit.org/attachment.cgi?id=22060&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
 #if USE(JAVASCRIPTCORE_BINDINGS)
+#include "RenderWidget.h"
 #include "runtime.h"
 #endif

I'd prefer to add this include outside the #if, even if it's not required; my
idea would be to minimize #include inside #if when possible.

r=me


More information about the webkit-reviews mailing list