[webkit-reviews] review denied: [Bug 19991] WebKit needs cross-platform filter system : [Attachment 22660] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 5 15:25:50 PDT 2008
Oliver Hunt <oliver at apple.com> has denied 's request for review:
Bug 19991: WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991
Attachment 22660: Patch
https://bugs.webkit.org/attachment.cgi?id=22660&action=edit
------- Additional Comments from Oliver Hunt <oliver at apple.com>
FilterBuilder::getEffectById
id == 0 should be id.isEmpty()
Should m_lastEffect be guaranteed to be non-null? (eg. shouldn't it
initially be a wrapper around with the original input?)
I'm also not sure about the changes to
WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp -- i would appreciate it
if you could get eric to have a look.
Other than those issues it looks good -- i'll have to spend real time reviewing
to to give a more thorough review though, but i'll leave that until after these
above issues are dealt with.
More information about the webkit-reviews
mailing list