[webkit-reviews] review requested: [Bug 16881] [GTK] PlatformScreenGtk is unimplemented : [Attachment 22659] Implement stubs
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 5 12:40:10 PDT 2008
Marco Barisione <marco.barisione at collabora.co.uk> has asked for review:
Bug 16881: [GTK] PlatformScreenGtk is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=16881
Attachment 22659: Implement stubs
https://bugs.webkit.org/attachment.cgi?id=22659&action=edit
------- Additional Comments from Marco Barisione
<marco.barisione at collabora.co.uk>
- Fixed the non-X11 build issue
- Return values != 0 if the containing window is null
I didn't replace the FloatRect with an IntRect because it would makes the code
longer and IMHO less readable (the conversion is needed immediately after the
creation of the rect).
The Firefox behaviour seems broken for instace it seems to cache values so it
returns the wrong value if you add/remove a monitor and it doesn't consider
panels, so screen.availHeight/Width is always = screen.height/width.
More information about the webkit-reviews
mailing list