[webkit-reviews] review denied: [Bug 20020] Proposed enhancement to JavaScriptCore API : [Attachment 22627] Add new API functions (JSObjectMake(Array|Date|Error|RegExp)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 4 12:29:46 PDT 2008


Geoffrey Garen <ggaren at apple.com> has denied Kelvin Sherlock
<ksherlock at gmail.com>'s request for review:
Bug 20020: Proposed enhancement to JavaScriptCore API
https://bugs.webkit.org/show_bug.cgi?id=20020

Attachment 22627: Add new API functions (JSObjectMake(Array|Date|Error|RegExp)
https://bugs.webkit.org/attachment.cgi?id=22627&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Your copyright should go into JSObjectRef.h, as well.

The ChangeLog should mention the bug number and what the API added. If you're
not going to specifically comment on each function you changed, you can leave
that boilerplate function list out.

+ @abstract Creates a JavaScript RefExp object

Typo: "RefExp" should be "RegExp".

Otherwise, this is ready to land.

I have to r- over the copyright issue, though :(.


More information about the webkit-reviews mailing list