[webkit-reviews] review granted: [Bug 20119] Execute CSS Animations : [Attachment 22437] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 4 11:57:13 PDT 2008


Dave Hyatt <hyatt at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 20119: Execute CSS Animations
https://bugs.webkit.org/show_bug.cgi?id=20119

Attachment 22437: Updated patch
https://bugs.webkit.org/attachment.cgi?id=22437&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Everything looks fine to me.  I am concerned that the line I linked above could
cause a performance regression, since you've added extra work to setStyle for
every single RenderObject on a page by removing that null check.

r=me, but because of the setAnimatableStyle change you will need to run the
performance tests before this can be landed to verify that no regression is
caused.


More information about the webkit-reviews mailing list