[webkit-reviews] review denied: [Bug 20253] A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it : [Attachment 22621] Take 3 on flex checking

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Kalle Vahlman
<zuh at iki.fi>'s request for review:
Bug 20253: A correct Webkit build requires flex 2.5.33 but autotools build
doesn't check for it
https://bugs.webkit.org/show_bug.cgi?id=20253

Attachment 22621: Take 3 on flex checking
https://bugs.webkit.org/attachment.cgi?id=22621&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>+   FLEX_VERSION=`$FLEX --version | sed 's,.*\
\([0-9]*\.[0-9]*\.[0-9]*\)$,\1,'`
>+   AX_COMPARE_VERSION([2.5.33],[gt],[$FLEX_VERSION],
>+	AC_MSG_ERROR([You need at least version 2.5.33 of the 'flex' lexer
generator to compile WebKit]))
> fi

Shouldn't that be "[ge]" since 2.5.33 works?