[webkit-reviews] review granted: [Bug 20013] Windows AX huerusitics are poor : [Attachment 22582] Update patch for Separator Role

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 20013: Windows AX huerusitics are poor
https://bugs.webkit.org/show_bug.cgi?id=20013

Attachment 22582: Update patch for Separator Role
https://bugs.webkit.org/attachment.cgi?id=22582&action=edit

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
r=me! Some very minor typos:

>+	  * page/AccessibilityObject.h:
>+	  (WebCore::):Add Separator Role to AccessibilityRole enum.

Missing a space before Add, extra space in SeparatorRole.

>+	  (WebCore::AccessibilityRenderObject::canSetFocusAttribute): return
>+	  false for <hr> tags, matching Firefox.

Lower case 'r' in return.

>+	  * win/AccessibleBase.cpp:
>+	  (MSAARole):return ROLE_SYSTEM_SEPARATOR for Separator roles.

Missing space and lower case 'r' in return, "Separator roles" -> SeparatorRole.


Thanks for the patch!