[webkit-reviews] review granted: [Bug 20212] [XBL] Add full support for element="" attachment : [Attachment 22618] Second attempt: updated with Eric's comment + removed issue I had spotted (added a test case for that)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 3 00:15:18 PDT 2008
Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 20212: [XBL] Add full support for element="" attachment
https://bugs.webkit.org/show_bug.cgi?id=20212
Attachment 22618: Second attempt: updated with Eric's comment + removed issue I
had spotted (added a test case for that)
https://bugs.webkit.org/attachment.cgi?id=22618&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks OK. Please add a test case which fails due to this FIXME:
53 // FIXME: If we have an XBLDocument, we need to get the bound
document.
54 Document* boundDocument = document();
when you land.
More information about the webkit-reviews
mailing list