[webkit-reviews] review granted: [Bug 20036] wxWebKit wxPy binary packager for Win : [Attachment 22276] patch to build a Win installer for wxWebKit binaries

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 20036: wxWebKit wxPy binary packager for Win
https://bugs.webkit.org/show_bug.cgi?id=20036

Attachment 22276: patch to build a Win installer for wxWebKit binaries
https://bugs.webkit.org/attachment.cgi?id=22276&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think the license for the App would actually be a BSD or LGPL license judging
by the code in WebKit.

retval = os.path.abspath(os.path.join(__file__,"..","..", "..", "WebKitBuild"))

WebKit style says there should be a space after each ,

Your svnrevision lookup should ideally be a function call so that it's easier
to add Git-svn support later.  Many WebKit hackers use git-svn these days.

Otherwise this looks fine.  Since you're a committer, I trust you can fix these
all w/o needing to upload another patch.

Thanks!