[webkit-reviews] review denied: [Bug 19447] [Qt] First line of links not underlined correctly in some cases : [Attachment 21742] Option 3 of 3: Explicitly set the stroke style before drawing text underline

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 1 15:43:35 PDT 2008


Eric Seidel <eric at webkit.org> has denied Simon Hausmann <hausmann at webkit.org>'s
request for review:
Bug 19447: [Qt] First line of links not underlined correctly in some cases
https://bugs.webkit.org/show_bug.cgi?id=19447

Attachment 21742: Option 3 of 3: Explicitly set the stroke style before drawing
text underline
https://bugs.webkit.org/attachment.cgi?id=21742&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
dhyatt>
css3 is going to allow lines drawn for text
[3:36pm] <dhyatt>
to be other stroke styles
[3:36pm] <dhyatt>
so i don't like that
[3:37pm] <dhyatt>
that essentially hardcodes a solid stroke for this api
[3:37pm] <dhyatt>
it's supposed to use the current stroke style
[3:37pm] <dhyatt>
we should fix inlinetextbox
[3:38pm] <dhyatt>
not work around it


More information about the webkit-reviews mailing list