[webkit-reviews] review denied: [Bug 18548] Web Inspector freezes if a search fires with a small number of letters : [Attachment 21356] Proposed patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Eric Seidel
<eric at webkit.org>'s request for review:
Bug 18548: Web Inspector freezes if a search fires with a small number of
letters
https://bugs.webkit.org/show_bug.cgi?id=18548

Attachment 21356: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=21356&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
+    var forceSearch = event.keyCode == 13;

You should use event.keyIdentifier === "Enter" here.

+    if (!forceSearch && this.lastQuery && this.lastQuery == query)

You should use === here.

Otherwise I will r+ it.