[webkit-reviews] review denied: [Bug 19690] SharedBuffer::buffer() fails with platform data : [Attachment 21857] Patch to fix the buffer() call to properly use the platform data if available

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 19690: SharedBuffer::buffer() fails with platform data
https://bugs.webkit.org/show_bug.cgi?id=19690

Attachment 21857: Patch to fix the buffer() call to properly use the platform
data if available
https://bugs.webkit.org/attachment.cgi?id=21857&action=edit

------- Additional Comments from Anders Carlsson <andersca at apple.com>
 I think that we should state that calling buffer() on a SharedBuffer that
wraps platform data is invalid, and add an assert.

I don't blindly want to add a maybeTransferPlatformData() because that is a
potentially expensive operation and we'd like to avoid that, especially since
buffer() returns a const reference.