[webkit-reviews] review granted: [Bug 14377] Support disabling individual CSS properties : [Attachment 22604] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 1 12:47:13 PDT 2008

Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 14377: Support disabling individual CSS properties

Attachment 22604: Proposed patch

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+Object.hasProperties = function(obj)
+    if (!obj)
+	 return false;

This doesn't seem right. Won't the empty string evaluate to false here, even
though it has properties?

I personally dislike booleans with a negative meaning, so everywhere you have a
boolean "disabled" (or a class "disabled") I wish it were "enabled" instead. I
find that easier to understand, because you end up with fewer double-negatives,
like if (!disabled).

It would be great to land some tests with this.


More information about the webkit-reviews mailing list