[webkit-reviews] review requested: [Bug 20246] Implement RenderTheme::systemColor() for Windows : [Attachment 22590] Call through to GetSysColor() for RenderThemeSafari::systemColor()

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked Adam Roben (aroben) <aroben at apple.com>
for review:
Bug 20246: Implement RenderTheme::systemColor() for Windows
https://bugs.webkit.org/show_bug.cgi?id=20246

Attachment 22590: Call through to GetSysColor() for
RenderThemeSafari::systemColor()
https://bugs.webkit.org/attachment.cgi?id=22590&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks OK.  The switch style is probably wrong by WebKit standards.  I'd almost
consider using a HashMap here, except that'd be a bunch of memory on the heap
for no real need.

I wonder if we need any kind of caching here?  Color does some amount of
caching, but I don't think that applies here.

Adam Roben should comment.