[webkit-reviews] review requested: [Bug 18665] HTMLTokenizer double allocates strings for <script> : [Attachment 21094] Updated patch, this one with a changelog.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 18665: HTMLTokenizer double allocates strings for <script>
https://bugs.webkit.org/show_bug.cgi?id=18665

Attachment 21094: Updated patch, this one with a changelog.
https://bugs.webkit.org/attachment.cgi?id=21094&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
I assume he meant to mark this for review.

One style nit:
+    if (t->tagName == textAtom && t->text && current->localName() !=
scriptTag)
+    {

{ should be on the same line as the if in WebKit style.

Also, generally the changelog reads:
date/name line
blank
reviewed by line
blank
description and link to bug
blank
test cases (if applicable)
blank
comments on individual files.

The patch looks good to me, but I think someone else who has hacked in this
code recently should at least glance at it.