[webkit-reviews] review requested: [Bug 18489] Squirrelfish doesn't build on linux : [Attachment 20886] Build, template, macros fixes for Linux

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 29 02:21:04 PDT 2008

Gabor Loki <loki at inf.u-szeged.hu> has asked  for review:
Bug 18489: Squirrelfish doesn't build on linux

Attachment 20886: Build, template, macros fixes for Linux

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
This patch is for revision 32670.

The proposed fix contains the followings:
- rename JavaScriptCore/kjs/LocalStorage.h to
JavaScriptCore/kjs/LocalStorageEntry.h (like in
http://trac.webkit.org/changeset/32259), but I didn't able to update XCode
Project file. Please someone (who have a Mac) update this.

- template problem in JavaScriptCore/kjs/collector.{h,cpp}: A new template
instance (like in 'allocateNumber') cannot be created only from forward

- add missing QT_*_NAMESPACE defines (like in

- add some missing includes and sources

More information about the webkit-reviews mailing list