[webkit-reviews] review requested: [Bug 18749] SQUIRRELFISH: const support is broken : [Attachment 20881] Patch in progress

[bugzilla-daemon at webkit.org]

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 18749: SQUIRRELFISH: const support is broken
http://bugs.webkit.org/show_bug.cgi?id=18749

Attachment 20881: Patch in progress
http://bugs.webkit.org/attachment.cgi?id=20881&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Here is a patch that implements all of the necessary codegen for const. It
passes almost all of the const tests, the only exception being things of the
form:

const x = 1;

function f() { x = 2; }

This is because the attributes are not respected at runtime in
JSVariableObject. I'm not quite sure of the best way to store them.