[webkit-reviews] review denied: [Bug 18568] background: currentColor fails : [Attachment 20849] First attempt

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Rob Buis <rwlbuis at gmail.com>'s request for review:
Bug 18568: background: currentColor fails
http://bugs.webkit.org/show_bug.cgi?id=18568

Attachment 20849: First attempt
http://bugs.webkit.org/attachment.cgi?id=20849&action=edit

------- Additional Comments from mitz at webkit.org
You have an unrelated test and result in the patch.

Since you have text in the render tree dump, the expected results should go
into a platform-specific directory. As alternatives, you could make a text-only
test using getComputedStyle, or just remove all text from the test.

CSS3 says "If the 'currentColor' keyword is set on the 'color' property itself,
it is treated as 'color:inherit' at parse time". I don't understand how the
patch satisfies this. I think it should be included in the test (maybe only
testable by having a cascade where the first rule sets color: to something
different from the parent's and the second sets it to inherit).