[webkit-reviews] review requested: [Bug 18661] Proxy server issue in Sunday's Nightly : [Attachment 20869] updated fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 28 10:00:22 PDT 2008

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 18661: Proxy server issue in Sunday's Nightly

Attachment 20869: updated fix

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
(In reply to comment #10)
> This needs to use the ALWAYS_INLINE macro so it will compile in non-GCC
> compilers.

Oops - this wasn't even supposed to be in the patch, was just an experiment.

> We normally put the struct declarations in a separate paragraph below the
> ones.


> We normally omit else before return.


>  134	       usleep(1000);

This file is currently only used on Mac.

More information about the webkit-reviews mailing list