[webkit-reviews] review granted: [Bug 18550] cross-frame-access-call.html doesn't really test window.open(), since popups are blocked : [Attachment 20673] add layoutTestController.setCanOpenWindows(true)

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Eric Roman
<minatoar at gmail.com>'s request for review:
Bug 18550: cross-frame-access-call.html doesn't really test window.open(),
since popups are blocked
http://bugs.webkit.org/show_bug.cgi?id=18550

Attachment 20673: add layoutTestController.setCanOpenWindows(true)
http://bugs.webkit.org/attachment.cgi?id=20673&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+2008-04-18  Eric Roman  <minatoar at gmail.com>
+
+	 Reviewed by NOBODY (OOPS!).
+
+	 * http/tests/security/cross-frame-access-call-expected.txt: Increase a
console line number (since added two lines)
+	 * http/tests/security/cross-frame-access-call.html: Enable popups for
this layout test. The test checks that window.open is returns undefined
(same-domain enforcement), however unless popups are enabled it returns
undefined regardless.
+

It's customary to list the bug title and URL of the bug you're fixing in your
ChangeLog entry (though I think unfortunately this is not mentioned on our
website anywhere). Whomever lands this patch can add that for you.

r=me. Thanks!