[webkit-reviews] review requested: [Bug 18746] SQUIRRELFISH: indirect eval used when direct eval should be used : [Attachment 20835] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 26 14:34:34 PDT 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 18746: SQUIRRELFISH: indirect eval used when direct eval should be used
http://bugs.webkit.org/show_bug.cgi?id=18746

Attachment 20835: Proposed patch
http://bugs.webkit.org/attachment.cgi?id=20835&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Here is a proposed patch. It fixes the 4 eval layout tests as well
fast/js/encode-URI-test. Unfortunately, on my machine it is a 0.8% regression
on SunSpider. I'll try doing the usual tricks, but maybe somebody can check it
on their machine.


More information about the webkit-reviews mailing list