[webkit-reviews] review requested: [Bug 18617] [CAIRO] SVG fonts get the wrong color (always black) : [Attachment 20823] Display texts in SVG and HTML

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 25 13:44:00 PDT 2008


Dirk Schulze <vbs85 at gmx.de> has asked  for review:
Bug 18617: [CAIRO] SVG fonts get the wrong color (always black)
http://bugs.webkit.org/show_bug.cgi?id=18617

Attachment 20823: Display texts in SVG and HTML
http://bugs.webkit.org/attachment.cgi?id=20823&action=edit

------- Additional Comments from Dirk Schulze <vbs85 at gmx.de>
This patch fixes the problem with displaying texts in SVG and HTML. I had to
use a workaround to get a full support.

I had to hard-code the fill-rule for SVG's to CAIRO_FILL_RULE_EVEN_ODD to
differentiate between HTML- and SVG-texts. For HTML-text the font-color has to
be hard-coded at present. If you don't do it (e.g. use of
setPlatformFillColor(), see attachment above) not all HTML-objects are
displayed right.
HTML makes only use of CAIRO_FILL_RULE_WINDING.

I couldn't find any optical differences in SVG between the two fill-rules.

This patch fixes bug-report: 18663, 15619 too.


More information about the webkit-reviews mailing list