[webkit-reviews] review requested: [Bug 18732] SQUIRRELFISH: exceptions thrown by native constructors are ignored : [Attachment 20809] Revised proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 24 22:05:59 PDT 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 18732: SQUIRRELFISH: exceptions thrown by native constructors are ignored
http://bugs.webkit.org/show_bug.cgi?id=18732

Attachment 20809: Revised proposed patch
http://bugs.webkit.org/attachment.cgi?id=20809&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
We should do the exception check before writing to any register. The code
currently doing the check after writing is incorrect. This version does
slightly better on SunSpider, for a pretty definite 0.4% progression.


More information about the webkit-reviews mailing list