[webkit-reviews] review requested: [Bug 18717] SQUIRRELFISH: eval returns the wrong value for a variable declaration statement : [Attachment 20802] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 24 15:29:50 PDT 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 18717: SQUIRRELFISH: eval returns the wrong value for a variable
declaration statement
http://bugs.webkit.org/show_bug.cgi?id=18717

Attachment 20802: Proposed patch
http://bugs.webkit.org/attachment.cgi?id=20802&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Yeah, Oliver, I accidentally misread the spec. Here is a patch that fixes the
problem. It seems to be a 0.2% progression on SunSpider. It fixes
ecma_3/Expressions/11.9.6-1.js, but causes js1_5/GetSet/getset-005.js to crash,
like many other tests using getters and setters.


More information about the webkit-reviews mailing list