[webkit-reviews] review granted: [Bug 18677] Synchronous event dispatch confuses the popup blocker into incorrectly blocking chat popups @ gmail.com : [Attachment 20752] Patch of kjs_events.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 23 07:52:38 PDT 2008


Geoffrey Garen <ggaren at apple.com> has granted Feng Qian
<ian.eng.webkit at gmail.com>'s request for review:
Bug 18677: Synchronous event dispatch confuses the popup blocker into
incorrectly blocking chat popups @ gmail.com
http://bugs.webkit.org/show_bug.cgi?id=18677

Attachment 20752: Patch of kjs_events.cpp
http://bugs.webkit.org/attachment.cgi?id=20752&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
+	 Event* saved_event = windowWrapper->window()->currentEvent();

According to our style guidelines, variable names should use camelCase, so
"saved_event" should be named "savedEvent".


More information about the webkit-reviews mailing list