[webkit-reviews] review requested: [Bug 18634] SQUIRRELFISH: correctly handle variable and function declarations in eval code : [Attachment 20761] Proposed patch implementing function declarations in eval code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 22 19:16:42 PDT 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 18634: SQUIRRELFISH: correctly handle variable and function declarations in
eval code
http://bugs.webkit.org/show_bug.cgi?id=18634

Attachment 20761: Proposed patch implementing function declarations in eval
code
http://bugs.webkit.org/attachment.cgi?id=20761&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
This patch implements function declarations in eval code. In the process, it
fixes 12 JavaScriptCore test failures.

Should declaredVariables and declaredFunctions be declaredVariableIdentifiers
and declaredFunctionIdentifiers?


More information about the webkit-reviews mailing list