[webkit-reviews] review granted: [Bug 18671] SquirrelFish: continue
inside switch fails : [Attachment 20741] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 21 16:23:49 PDT 2008
Oliver Hunt <oliver at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 18671: SquirrelFish: continue inside switch fails
http://bugs.webkit.org/show_bug.cgi?id=18671
Attachment 20741: Proposed patch
http://bugs.webkit.org/attachment.cgi?id=20741&action=edit
------- Additional Comments from Oliver Hunt <oliver at apple.com>
I'd prefer:
+ if (forContinue) {
+ for (int i = m_jumpContextStack.size() - 1; i >= 0; i--) {
+ JumpContext* scope = &m_jumpContextStack[i];
+ if (scope->continueTarget)
+ return scope;
+ }
+ return 0;
+ }
But other than that, r=me
More information about the webkit-reviews
mailing list