[webkit-reviews] review granted: [Bug 18601] Add the UI portions of the Scripts panel : [Attachment 20678] Initial UI portions of the Scripts panel

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 21 11:36:22 PDT 2008


Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 18601: Add the UI portions of the Scripts panel
http://bugs.webkit.org/show_bug.cgi?id=18601

Attachment 20678: Initial UI portions of the Scripts panel
http://bugs.webkit.org/attachment.cgi?id=20678&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+    this.pauseButton.appendChild(document.createElement("img"));

Why do we need these <img> elements? Can we just set content: on the <button>?
Maybe the <img> is needed to autosize the button?

+#scripts-sidebar-resizer-widget {
+    position: absolute;
+    top: 0;
+    bottom: 0;
+    right: 225px;
+	width: 16px;
+	cursor: col-resize;
+	background-image: url(Images/statusbarResizerHorizontal.png);
+	background-repeat: no-repeat;
+	background-position: center;
+}

Looks like indentation got screwy here.

r=me, but I do think it would be good to split out the changes to existing UI
from the new stuff and land them first.


More information about the webkit-reviews mailing list