[webkit-reviews] review requested: [Bug 18634] SQUIRRELFISH: correctly handle variable and function declarations in eval code : [Attachment 20718] Revised proposed patch

[bugzilla-daemon at webkit.org]

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 18634: SQUIRRELFISH: correctly handle variable and function declarations in
eval code
http://bugs.webkit.org/show_bug.cgi?id=18634

Attachment 20718: Revised proposed patch
http://bugs.webkit.org/attachment.cgi?id=20718&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
It turns out that the cause of the speedup was a GC bug in string-tagcloud,
where the EvalCodeBlocks were not getting marked. Here is a patch that fixes
the GC bug by treating EvalCodeBlocks like ProgramCodeBlocks. This time there
is no difference on SunSpider.