[webkit-reviews] review granted: [Bug 18619] Support continue, break, and return in try .. finally blocks : [Attachment 20688] Rewrite finalisers with the wonder and joy of jsr/sret

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 18619: Support continue, break, and return in try .. finally blocks
http://bugs.webkit.org/show_bug.cgi?id=18619

Attachment 20688: Rewrite finalisers with the wonder and joy of jsr/sret
http://bugs.webkit.org/attachment.cgi?id=20688&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
The code seems ok on the substance, so I'll say r=me.

But here are some style suggestions:

1) The return address register is variously named it's returnRegister,
returnAddrRegister, returnAddress, and in some confusing cases,
returnAddressnReg. I think it should be retAddrDst (or returnAddrDst) for jsr,
and retAddrSrc (or returnAddrSrc) for sret, just to make clear these
instructions respectively read and write the return address.

2) Is it really right to call a finally block a "finaliser"? In the context of
dynamic languages, a "finaliser" is typically a routine that runs when a
garbage-collected object is destroyed.

3) In emitComplexJumpScopes, I would advise you to consider breaking some of
the commented blocks into well-named helper functions.