[webkit-reviews] review granted: [Bug 18585] Frame::ownerRenderer() is likely causing strange crashes : [Attachment 20671] Actually fix the ASSERT/potential crasher

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 18 13:27:16 PDT 2008


Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 18585: Frame::ownerRenderer() is likely causing strange crashes
http://bugs.webkit.org/show_bug.cgi?id=18585

Attachment 20671: Actually fix the ASSERT/potential crasher
http://bugs.webkit.org/attachment.cgi?id=20671&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    if (!subtree && (!root->isRenderView() ||
!static_cast<RenderView*>(root)->printing()))

The isRenderView() check here isn't needed. If subtree is false, it's
guaranteed to be a RenderView.

Change looks OK otherwise.

r=me either as-is or with that fix


More information about the webkit-reviews mailing list