[webkit-reviews] review requested: [Bug 18550] cross-frame-access-call.html doesn't really test window.open(), since popups are blocked : [Attachment 20673] add layoutTestController.setCanOpenWindows(true)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 18 12:31:45 PDT 2008


Eric Roman <minatoar at gmail.com> has asked  for review:
Bug 18550: cross-frame-access-call.html doesn't really test window.open(),
since popups are blocked
http://bugs.webkit.org/show_bug.cgi?id=18550

Attachment 20673: add layoutTestController.setCanOpenWindows(true)
http://bugs.webkit.org/attachment.cgi?id=20673&action=edit

------- Additional Comments from Eric Roman <minatoar at gmail.com>
Sorry about that aroben! Fixed, new patch uploaded.

I ran the layout test, and it passes. I did have to change a line number in the
expected output though, since this patch added two lines.


More information about the webkit-reviews mailing list