[webkit-reviews] review denied: [Bug 18550]
cross-frame-access-call.html doesn't really test window.open(),
since popups are blocked : [Attachment 20636] add
layoutTestController.setCanOpenWindows(true)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 18 07:01:22 PDT 2008
Adam Roben (aroben) <aroben at apple.com> has denied Eric Roman
<minatoar at gmail.com>'s request for review:
Bug 18550: cross-frame-access-call.html doesn't really test window.open(),
since popups are blocked
http://bugs.webkit.org/show_bug.cgi?id=18550
Attachment 20636: add layoutTestController.setCanOpenWindows(true)
http://bugs.webkit.org/attachment.cgi?id=20636&action=edit
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
Thanks for the patch!
You should leave the "requestee" field blank in most cases when putting a patch
up for review.
You'll need to create a ChangeLog entry. See
<http://webkit.org/coding/contributing.html> for information on how to prepare
and submit a patch.
Have you verified that the test still passes?
r- so that a ChangeLog can be added.
More information about the webkit-reviews
mailing list