[webkit-reviews] review granted: [Bug 18357] [GTK] Enter on buttons doesn't work : [Attachment 20402] Set the text of the event to '\r' when the return/enter key is pressed

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Marco Barisione
<marco.barisione at collabora.co.uk>'s request for review:
Bug 18357: [GTK] Enter on buttons doesn't work
http://bugs.webkit.org/show_bug.cgi?id=18357

Attachment 20402: Set the text of the event to '\r' when the return/enter key
is pressed
http://bugs.webkit.org/attachment.cgi?id=20402&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
It's surprising that gdk_keyval_to_unicode doesn't handle these keys - what is
the story behind this? I couldn't find any hints in documentation. Are there
any other keys that need to be special cased?

Yes, it is correct to use \r here - JavaScript code on the Web expects to see
0x13 in keypress.charCode, so this is not just internal to WebCore.

I have noticed that windowsKeyCodeForKeyEvent doesn't handle GDK_ISO_Enter and
GDK_KP_Enter - this looks worth fixing, too.

r=me