[webkit-reviews] review denied: [Bug 15449] [CAIRO] SVG gradients do not work properly : [Attachment 20593] Fixed colors and drawing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 16 21:41:11 PDT 2008

Eric Seidel <eric at webkit.org> has denied Dirk Schulze <vbs85 at gmx.de>'s request
for review:
Bug 15449: [CAIRO] SVG gradients do not work properly

Attachment 20593: Fixed colors and drawing

------- Additional Comments from Eric Seidel <eric at webkit.org>
The patch in general looks fine.

We don't generally pre-declare variables at the top of a block.  That's C-style
and this is C++.
double cx, fx, cy, fy, radius, fradius; // one example

These are extra braces according to our style guidelines:
if ((fx + cx) <  cx) {
+		 fx = int(cos(angle) * radius) + 1;
+	     }

Otherwise it looks fine.

Why are there no test changes?	Does the GTK build still not have pixel tests?

More information about the webkit-reviews mailing list