[webkit-reviews] review denied: [Bug 17331] Change postMessage/MessageEvent to match HTML5 wrt. exposing origin vs. domain/uri : [Attachment 20562] Updated patch to fix bit rot

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Collin Jackson
<collinj-webkit at collinjackson.com>'s request for review:
Bug 17331: Change postMessage/MessageEvent to match HTML5 wrt. exposing origin
vs. domain/uri
http://bugs.webkit.org/show_bug.cgi?id=17331

Attachment 20562: Updated patch to fix bit rot
http://bugs.webkit.org/attachment.cgi?id=20562&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
The changes here look good.

I think the changes to WebSecurityOrigin in WebKit/mac will break Safari 3.1,
since it won't be able to find the -domain method. The WebKit/win changes
should be fine because you're just renaming the function, not relocating it in
the vtable.

The same changes you've made to DRT/mac need to be made to DRT/win.

It would be a little clearer to rename the origin argument to postMessage to
"targetOrigin". It looks like HTML 5 is headed in this direction as well (see
<http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2008-April/014414.html>).

If you are feeling up to it, it would be nice to see this patch broken up into
smaller independent changes. Some pieces that I think could be broken off:

1. Removal of the m_portSet member from SecurityOrigin.
2. Renaming stringIdentifier -> databaseIdentifier
3. Adding m_domain and domain()
4. Changing SecurityOrigin constructor to take a KURL

This isn't required, but would make reviewing easier.

r- so that we can address the WebSecurityOrigin/DRT issues.