[webkit-reviews] review requested: [Bug 10794] [CSS1] Background-attachment: scroll should scroll within the containing block : [Attachment 20557] patch (updated 2)

[bugzilla-daemon at webkit.org]

Anatoli Papirovski <apapirovski at mac.com> has asked  for review:
Bug 10794: [CSS1] Background-attachment: scroll should scroll within the
containing block
http://bugs.webkit.org/show_bug.cgi?id=10794

Attachment 20557: patch (updated 2)
http://bugs.webkit.org/attachment.cgi?id=20557&action=edit

------- Additional Comments from Anatoli Papirovski <apapirovski at mac.com>
Ok, hopefully this is the final patch. I've modified my test case to also test
background-origin for background-size on root element.

Also, while I was testing that I noticed that WebKit's implementation of
background-size: 50% auto;, that is percentage width and auto height, was
broken and so I just quickly fixed it... was there a reason why it was that
way, which I missed? (The formula that was there for calculation did not make
any sense what-so-ever.) There is no separate ticket for that and I didn't
think it was worth creating one for a change of one variable.

No test case was needed for that one, as there is one in fast/backgrounds/size
... it's the number 18.