[webkit-reviews] review denied: [Bug 18473] Animation <use> fixes : [Attachment 20522] <use> fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 14 13:56:22 PDT 2008

Eric Seidel <eric at webkit.org> has denied Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 18473: Animation <use> fixes

Attachment 20522: <use> fixes

------- Additional Comments from Eric Seidel <eric at webkit.org>
I prefer arguments to have more informative names than "b":
"blockUpdates" perhaps?

Is gElementsWithInstanceUpdatesBlocked the official pattern now? I thought s_

 void SVGUseElement::removeDisallowedElementsFromSubtree(Node* element)

needs a comment as to why RefPtr<Node> is not required to protect against
MutationEvent listeners doing bad things.

+bool SVGSMILElement::isSMILElement(Node* node)
I'm surprised that's even needed.  I guess I would have figured there would
have been a virtual bool isSVGSMILElement() const { return false; } on

r- due to the possible crasher due to mutation events (or lack of comment)

More information about the webkit-reviews mailing list