[webkit-reviews] review denied: [Bug 18230] tspan in link not working : [Attachment 20308] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 13 22:32:37 PDT 2008

Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 18230: tspan in link not working

Attachment 20308: First attempt

------- Additional Comments from Eric Seidel <eric at webkit.org>
This is *great*.  But I don't think it's safe to assume that your parent is
always an SVG element:

if (static_cast<SVGElement*>(parent()))

I bet that it's possible to add an SVGAElement into an arbitrary XML DOM and we
don't prevent that.  Whether we should is another question.  You'll need to
check the type of the parent before making the case.

r- for the potential crasher.

More information about the webkit-reviews mailing list