[webkit-reviews] review requested: [Bug 18347] Absolutely positioned image percentage width does not respect container's padding : [Attachment 20515] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 13 20:09:25 PDT 2008


Anatoli Papirovski <apapirovski at mac.com> has asked  for review:
Bug 18347: Absolutely positioned image percentage width does not respect
container's padding
http://bugs.webkit.org/show_bug.cgi?id=18347

Attachment 20515: patch
http://bugs.webkit.org/attachment.cgi?id=20515&action=edit

------- Additional Comments from Anatoli Papirovski <apapirovski at mac.com>
I went over the specs and seems to me like the test case was correct, not to
mention that webkit was already doing the correct thing for the height, just
not for the width.

This is my first patch, I tried my best, but I'm sure there's bound to be
errors... also, I made sure to run the webkit tests and found no regressions.
I'm new to this whole thing, so I appreciate any tips or corrections.


More information about the webkit-reviews mailing list