[webkit-reviews] review denied: [Bug 16447] onload called too many times for <svg:image> : [Attachment 20491] Fix the "avoid malloc" part

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 12 12:48:34 PDT 2008

Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 16447: onload called too many times for <svg:image>

Attachment 20491: Fix the "avoid malloc" part

------- Additional Comments from Eric Seidel <eric at webkit.org>
Two comments:

1.  I think SVG Load events might support capture, in which case you need to
dispatch the event anyway (unless you walk up the parent chain and check to see
if any parent has a capturing load event listener (which is what the comment is

hasListenerType(const AtomicString &eventType)
we put the & next to AtomicString, per our style guidelines.

Since you've pointed out yet another case that our testing missed, you might
want to write a test case to verify that we correctly support capturing load
event listeners (since this patch would have broken that).

r- for the broken event capture support.

More information about the webkit-reviews mailing list