[webkit-reviews] review granted: [Bug 18349] Add support for CSS-based gradients : [Attachment 20488] More improvements. Make sure not to break SVG zooming (not that it works anyway).

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 11 16:16:29 PDT 2008


Oliver Hunt <oliver at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 18349: Add support for CSS-based gradients
http://bugs.webkit.org/show_bug.cgi?id=18349

Attachment 20488: More improvements.  Make sure not to break SVG zooming (not
that it works anyway).
http://bugs.webkit.org/attachment.cgi?id=20488&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Conditional r=me
* needs stubs for other platforms
* I'd like a bug report to cover gradients in border-image
* The test is insufficient -- need tests for both radial and linear gradients,
also needs to cover gradients that extend beyond the bounds of an element, also
infinite and nan control points for the gradient.  I'd also like the behaviour
out side the bounds of the gradient to be defined. eg. a gradient from
10%,10%->90%,90% what is the colour at 5%,5%, or 95%,95%


More information about the webkit-reviews mailing list