[webkit-reviews] review granted: [Bug 18418] REGRESSION (r31736?): DOM tree disappears when navigating to a new page with the Inspector open : [Attachment 20484] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 18418: REGRESSION (r31736?): DOM tree disappears when navigating to a new
page with the Inspector open
http://bugs.webkit.org/show_bug.cgi?id=18418

Attachment 20484: Patch
http://bugs.webkit.org/attachment.cgi?id=20484&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
@@ -141,8 +169,7 @@ WebInspector.ElementsPanel.prototype = {
	     this.focusedDOMNode = canidateFocusNode;
	     if (this.treeOutline.selectedTreeElement)
		 this.treeOutline.selectedTreeElement.expand();
-	 } else
-	     this.focusedDOMNode = null;
+	 }
     },

What's this change for? You don't mention it in the ChangeLog.

Maybe we should file a bug about the event listener being called with the
inspected page's global object?

r=me