[webkit-reviews] review denied: [Bug 18340] Elements with
display="none" in a <clipPath> still contribute to clipping
path : [Attachment 20440] First attempt
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 9 23:56:03 PDT 2008
Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 18340: Elements with display="none" in a <clipPath> still contribute to
clipping path
http://bugs.webkit.org/show_bug.cgi?id=18340
Attachment 20440: First attempt
http://bugs.webkit.org/attachment.cgi?id=20440&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Ok, so two things:
1. style error:
if ( pathStyle->display() != NONE )
(no spaces inside the ( ))
2. You should test visibility: hidden as well. What's the expected behavior
there?
Also:
// FIXME: How do we know the element has done a layout?
We could pretty easily test the not-yet-layout case, but I'm not sure that
layout even matters here, since we're calling a DOM method toClipPath(),
however I'm not sure the DOM can really get the right proportions... how does
it resolve lengths correctly?
We at least need a visibility: hidden test, IMO.
More information about the webkit-reviews
mailing list