[webkit-reviews] review requested: [Bug 18391] return body data incrementally from libsoup backend : [Attachment 20446] revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 9 19:14:21 PDT 2008


Dan Winship <danw at gnome.org> has asked	for review:
Bug 18391: return body data incrementally from libsoup backend
http://bugs.webkit.org/show_bug.cgi?id=18391

Attachment 20446: revised patch
http://bugs.webkit.org/attachment.cgi?id=20446&action=edit

------- Additional Comments from Dan Winship <danw at gnome.org>
checking SOUP_STATUS_IS_REDIRECTION() isn't quite right though, because in the
cases where it *doesn't* redirect on a 3xx response, we'd end up with no body
at the end...

Error messages should generally be short anyway, so I've just changed it so
that it provides the data incrementally for 2xx responses, and all at once at
the end still for non-2xx responses.


More information about the webkit-reviews mailing list