[webkit-reviews] review requested: [Bug 18375] Make SVG animation work : [Attachment 20419] Implement (most of) it

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has asked  for review:
Bug 18375: Make SVG animation work
http://bugs.webkit.org/show_bug.cgi?id=18375

Attachment 20419: Implement (most of) it
http://bugs.webkit.org/attachment.cgi?id=20419&action=edit

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
	It does
	- Full SMIL interval timing model including syncbase and event base
timing (the hard part).
	- CSS and XML attribute animation.
	- Linear, discrete and spline calcModes.
	- Values animation with keyTimes and keySplines.
	- Link activated animations.
	- Pretty good support for <animate> and <set> animations
	- Basic support for <animateColor>, <animateMotion> and
<animateTransform>.
	
	This passes some 35 of the 56 tests in W3C SVG animation test suite, a
bunch more
	with some subtest failures.
	
	What is still missing
	- Additive animation with multiple animations operating on the same
property. This is a
	  major architectural feature in animation code. It shouldn't be too
hard to add.
	- Only <animate> implements accumulate.
	- <animateMotion> does not do paths, keypoints, rotate.
	- <animateTransform> does not work with text, some transforms are
broken.
	- calcMode paced is missing.
	- repeat, beginEvent, endEvent are missing.
	- accesskey() is missing.
	- JS does not see correct values for baseVal/animVal, changing values
that are being
	  animted for a script produces wrong results. Not maintaining separate
presentation 
	  values for XML attributes is an architectural problem in our SVG
code.
	- Some other stuff I forgot or do not know about.

There are three new classes:

- SMILTime which implements time math including special "indefinite" and
"unresolved" values.
- SMILTimeContainer which runs the clock and manages animations ("time
container" is a SMIL term)
- SMILTimingElement, an abstract class which inherits SVGElement and is
inherited by SVGAnimationElement. It implements SMIL timing model semantics.