[webkit-reviews] review granted: [Bug 18371] Crash in KJS::JSValue::toObject closing Safari with Inspector open : [Attachment 20415] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 8 16:57:36 PDT 2008


Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 18371: Crash in KJS::JSValue::toObject closing Safari with Inspector open
http://bugs.webkit.org/show_bug.cgi?id=18371

Attachment 20415: Patch
http://bugs.webkit.org/attachment.cgi?id=20415&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
 130	     if (!inspectedWindow) {
 131		 this.rootDOMNode = null;
 132		 this.focusedDOMNode = null;
 133	     }

I think you need to return after setting focusedDOMNode here. Otherwise you'll
get an exception later when you access inspectedWindow.document.

r=me


More information about the webkit-reviews mailing list