[webkit-reviews] review granted: [Bug 18302] DumpRenderTree Resources out of Order causes failures in tests : [Attachment 20408] Proposed fix, and 3 updated layout tests

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Brady Eidson <beidson at apple.com>'s request for
review:
Bug 18302: DumpRenderTree Resources out of Order causes failures in tests
http://bugs.webkit.org/show_bug.cgi?id=18302

Attachment 20408: Proposed fix, and 3 updated layout tests
http://bugs.webkit.org/attachment.cgi?id=20408&action=edit

------- Additional Comments from mitz at webkit.org
+static NSInteger resourceURLSort(id resource1, id resource2, void *reverse)

I'd really prefer the name compareResourceURLs.

+	 if (NSArray* newSubresource = [subresources
sortedArrayUsingFunction:resourceURLSort context:&reverseSort])

The * should go next to newSubresource, which I'd call "newSubresourceS" or
"sortedSubresources".

Since the compare function does not use the context argument ("reverse"), just
pass 0, and don't call it "reverse".

r=me but please try to address some of my comments