[webkit-reviews] review denied: [Bug 18331] WebCore/svg/SVGAnimateMotionElement.cpp doesn't build when foreign objects are not enabled : [Attachment 20369] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 6 12:51:00 PDT 2008


Rob Buis <rwlbuis at gmail.com> has denied Mike Hommey <mh+webkit at glandium.org>'s
request for review:
Bug 18331: WebCore/svg/SVGAnimateMotionElement.cpp doesn't build when foreign
objects are not enabled
http://bugs.webkit.org/show_bug.cgi?id=18331

Attachment 20369: patch
http://bugs.webkit.org/attachment.cgi?id=20369&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
You should use 
#if ENABLE(SVG_FOREIGN_OBJECT)

instead, and provide a ChangeLog.


More information about the webkit-reviews mailing list