[webkit-reviews] review denied: [Bug 18024] [PATCH] Misnamed method preventing the method overriding : [Attachment 19983] rename the declared method in RenderCounter + ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 2 08:27:58 PDT 2008


Adam Roben (aroben) <aroben at apple.com> has denied Vincent Ricard
<magic at magicninja.org>'s request for review:
Bug 18024: [PATCH] Misnamed method preventing the method overriding
http://bugs.webkit.org/show_bug.cgi?id=18024

Attachment 19983: rename the declared method in RenderCounter + ChangeLog
http://bugs.webkit.org/attachment.cgi?id=19983&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
The patch looks fine, but please create a regression test as requested by Mitz
and Mark. You can find some information on our regression tests here:
<http://webkit.org/quality/testing.html>. The tests all reside in the
LayoutTests directory, and any new test placed in that directory will be
automatically found and run by the run-webkit-tests script.


More information about the webkit-reviews mailing list